Fix Files(IPFS) module status link and download link #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
XueMoMo
commented
Jan 15, 2024
XueMoMo
commented
- The old download link is no longer available, so we should use cf-ipfs.com
- Fix the status link to link to specific file information
|
@TarikGul are you able to look at this please sir ? |
TarikGul
requested changes
May 17, 2024
| @@ -43,7 +43,7 @@ const shortStr = (name: string, count = 6): string => { | |||
| }; | |||
|
|
|||
| function createUrl (f: SaveFile) { | |||
| const endpoint = f.UpEndpoint || 'https://ipfs.io'; | |||
| const endpoint = 'https://cf-ipfs.com'; | |||
There was a problem hiding this comment.
Why do we get rid of f.UpEdnpoint?
There was a problem hiding this comment.
Because currently UpEndpoint is only used for uploading files and cannot be used to access files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.