internal/dag: 0s HTTPRoute timeout disables the timeout #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Gateway API, a timeout specified as 0s (or any other explicitly zero-valued duration string) should disable the timeout rather than use the default value. Closes projectcontour#6373. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss
added
the
release-note/small
skriss
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
rajatvig and
clayton-gonsalves
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6375 +/- ##
=======================================
Coverage 81.59% 81.59%
=======================================
Files 133 133
Lines 15861 15865 +4
=======================================
+ Hits 12941 12945 +4
Misses 2624 2624
Partials 296 296
|
|
Ran GWAPI conformance test locally with a longer delay on the HTTP request ( |
sunjayBhatia
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gateway API, a timeout specified as 0s (or any
other explicitly zero-valued duration string) should disable the timeout rather than use the default
value.
Closes #6373.