Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for legacy Python 3.4 #287

Closed
wants to merge 3 commits into from
Closed

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 26, 2018

Changes proposed in this pull request:

  • It's not long until Python 3.4's EOL on 2019-03-16
  • Python 3.4 isn't used much
  • A backwards-incompatible release is coming up soon (dropping Python 2 Drop support for legacy Python 2 #281) so it's a good time to bundle this into a major version release
  • Upgrade Python syntax with pyupgrade `find . -name "*.py"` --py3-plus
  • Includes PR Drop support for legacy Python 2 #281 to avoid merge conflicts

Here's the pip installs for pylast from PyPI for last month:

category percent downloads
2.7 41.59% 2,123
3.6 36.85% 1,881
3.5 8.85% 452
null 5.99% 306
3.7 5.80% 296
3.4 0.82% 42
3.3 0.10% 5
Total 5,105

Source: pypistats python_minor --last-month pylast

image

https://github.com/hugovk/pypi-tools#examples

@hugovk hugovk added enhancement New feature or request backwards incompatible labels Nov 26, 2018
@hugovk
Copy link
Member Author

hugovk commented Nov 26, 2018

PR failed due to #171 but passed on my fork:

https://travis-ci.org/hugovk/pylast/builds/459953101

@hugovk
Copy link
Member Author

hugovk commented Nov 27, 2018

Closing in favour of #289, which can run tests and has also been rebased to remove merge conflicts.

@hugovk hugovk closed this Nov 27, 2018
@hugovk hugovk deleted the rm-2-and-3.4 branch November 27, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant