Fix select all features in attribute table #57140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agiudiceandrea
added
the
Bug
2 tasks
When selecting all features in attribute table, select only features visible in the table instead of all features in layer. Fixes qgis#55781 and qgis#53150
vaahtokarkki
force-pushed
the
fix-select-all-in-attribute-table
branch
from
e5109b0
to
11db401
Compare
|
Nice work indeed, but it seems to me that there is no consent over the expected behavior here: I have the feeling that |
|
Yeah that probably is the case, as it is discussed in #55781 (even though one could argue it to be a bit unexpected behaviour). Btw @elpaso, could you please review also my other PR #56825 that has been hanging there for over a month already? It should be just a simple bug fix and not a feature request as this turned out to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Select all action in attribute table selects all features from layer and disrespects any filtering done in the attribute table dialog. With this PR, the select all action will select all features visible in the table.
Fixes #53150
Fixes #55781 as copying features not present in the attribute table yields null values.