Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] Harmonize DXF Export app dialog and corresponding algorithm #57200

Merged
merged 5 commits into from Apr 23, 2024

Conversation

gacarrillor
Copy link
Member

@gacarrillor gacarrillor commented Apr 19, 2024

Follow-up: #56147

  • Remember settings for data defined blocks in DXF Export app dialog
  • Expose DXF Export's data defined blocks functionality to processing

image

Fix #56853


Funded by the QGIS user group Switzerland.

@gacarrillor gacarrillor marked this pull request as draft April 19, 2024 16:47
@github-actions github-actions bot added this to the 3.38.0 milestone Apr 19, 2024
@gacarrillor gacarrillor added Processing Relating to QGIS Processing framework or individual Processing algorithms DXF/DWG Relating to DXF or DWG importing/exporting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Apr 19, 2024
@qgis-bot
Copy link
Collaborator

@gacarrillor
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@gacarrillor
Copy link
Member Author

@mhugent, could you please bring the constant we'd talked about in #57036 (comment) to this PR/branch?

@mhugent
Copy link
Contributor

mhugent commented Apr 21, 2024

@mhugent, could you please bring the constant we'd talked about in #57036 (comment) to this PR/branch?

Created a PR against the branch in your repo (gacarrillor/QGIS)

@gacarrillor
Copy link
Member Author

Created a PR against the branch in your repo (gacarrillor/QGIS)

Thank you @mhugent!

@gacarrillor gacarrillor marked this pull request as ready for review April 22, 2024 12:51
@gacarrillor
Copy link
Member Author

@mhugent, since this PR fixes #56853, I'd really appreciate your review here.

@gacarrillor gacarrillor reopened this Apr 22, 2024
Copy link
Contributor

@mhugent mhugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.
The only thing that might be a bit confusing is that in the export dialog, there is 'Output Layer Attribute' and in processing, there is 'Attribute' and 'Output Layer Name'

@gacarrillor
Copy link
Member Author

Thank you, looks good to me. The only thing that might be a bit confusing is that in the export dialog, there is 'Output Layer Attribute' and in processing, there is 'Attribute' and 'Output Layer Name'

Thank you Marco. I guess we should also name it "Output layer attribute" in processing. Would that be enough to give more consistency?

@mhugent
Copy link
Contributor

mhugent commented Apr 23, 2024

Thank you Marco. I guess we should also name it "Output layer attribute" in processing. Would that be enough to give more consistency?

Yes, this will be fine

@gacarrillor
Copy link
Member Author

Thank you Marco. I guess we should also name it "Output layer attribute" in processing. Would that be enough to give more consistency?

Yes, this will be fine

Done!
image

@m-kuhn m-kuhn merged commit 8f6fcdc into qgis:master Apr 23, 2024
29 checks passed
@qgis-bot
Copy link
Collaborator

@gacarrillor
A documentation ticket has been opened at qgis/QGIS-Documentation#9045
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DXF/DWG Relating to DXF or DWG importing/exporting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DXF Export app functionality not offered by its processing alg and settings not remembered
4 participants