Support Rack 3 #187
Merged
Support Rack 3 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
approved these changes
Sep 15, 2023
|
I am totally fine with dropping old Ruby versions that are EOL if it makes things easier. |
|
Can you rebase? Thanks! |
Specs pass locally for me, running
RACK_VERSION=2.2.8 bundle && RACK_VERSION=2.2.8 bundle e rake
RACK_VERSION=3.0.8 bundle && RACK_VERSION=3.0.8 bundle e rake
|
Rebase done! |
ioquatix
reviewed
Sep 28, 2023
Triggered by
TESTOPTS=--seed=8264 b e rake
Seen in CI: https://github.com/rack/rack-contrib/actions/runs/6319320196/job/17160038534#step:4:88
I don't think we should be checking this.
See rack@161eb9d
We can avoid re-computing this on every request.
|
Let me know if I can do anything more here :) |
ioquatix
approved these changes
Oct 7, 2023
|
@ioquatix are you able to cut a new release with this? |
|
Released v2.4.0 - let me know if you have any issues. |
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All builds pass: https://github.com/dentarg/rack-contrib/actions/runs/6196721481
Builds on #186
Close #183