Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rack 3 #187

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Support Rack 3 #187

merged 4 commits into from
Oct 7, 2023

Commits on Sep 28, 2023

  1. Add support for Rack 3 

    Specs pass locally for me, running

    RACK_VERSION=2.2.8 bundle && RACK_VERSION=2.2.8 bundle e rake
    RACK_VERSION=3.0.8 bundle && RACK_VERSION=3.0.8 bundle e rake
    @dentarg
    dentarg committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8fa3c35 View commit details
    Browse the repository at this point in the history

  2. Rack 3 not supported on Ruby <2.3

    @dentarg
    dentarg committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    34d5dea View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Remove another crazy spec 

    Triggered by

    TESTOPTS=--seed=8264 b e rake

Seen in CI: https://github.com/rack/rack-contrib/actions/runs/6319320196/job/17160038534#step:4:88

I don't think we should be checking this.

See rack@161eb9d
    @dentarg
    dentarg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9b8a8ca View commit details
    Browse the repository at this point in the history

  2. Determine which header class to use earlier 

    We can avoid re-computing this on every request.
    @dentarg
    dentarg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    836bf7d View commit details
    Browse the repository at this point in the history