Skip to content

Commit

Permalink
rename _snowman to _e
Browse files Browse the repository at this point in the history
  • Loading branch information
@wycats
wycats committed Aug 9, 2010
1 parent 6767946 commit 7171161
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion actionpack/lib/action_view/helpers/form_tag_helper.rb
View file
Expand Up @@ -538,7 +538,7 @@ def html_options_for_form(url_for_options, options, *parameters_for_url)

def extra_tags_for_form(html_options)
snowman_tag = tag(:input, :type => "hidden",
:name => "_snowman", :value => "☃".html_safe)
:name => "_e", :value => "☃".html_safe)

method = html_options.delete("method").to_s

Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/template/form_helper_test.rb
View file
Expand Up @@ -1513,7 +1513,7 @@ def test_form_for_with_labelled_builder

def snowman(method = nil)
txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_snowman" type="hidden" value="&#9731;" />}
txt << %{<input name="_e" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
Expand Down
2 changes: 1 addition & 1 deletion actionpack/test/template/form_tag_helper_test.rb
View file
Expand Up @@ -12,7 +12,7 @@ def snowman(options = {})
method = options[:method]

txt = %{<div style="margin:0;padding:0;display:inline">}
txt << %{<input name="_snowman" type="hidden" value="&#9731;" />}
txt << %{<input name="_e" type="hidden" value="&#9731;" />}
txt << %{<input name="_method" type="hidden" value="#{method}" />} if method
txt << %{</div>}
end
Expand Down

15 comments on commit 7171161

@reu
Copy link
Contributor

@reu reu commented on 7171161 Aug 9, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh noes! This is a sad day for rails =/

@sikachu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I request a revert of this commit :(

@jm3
Copy link

@jm3 jm3 commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

melting

@kirel
Copy link

@kirel kirel commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo!

@adrianpacala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please STFU already - it's getting annoying. Thank you.

@paukul
Copy link
Contributor

@paukul paukul commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STFU? Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo!

@stygeo
Copy link

@stygeo stygeo commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noooooooooo, not the snowman! :( I also request a revert of this commit.

@davout
Copy link

@davout davout commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for reverting this commit, "rails snowman" will be an easier google query than "rails e" for the lost souls wondering what the hell their app is hiding in their request parameters

@paukul
Copy link
Contributor

@paukul paukul commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about using a name that describes the purpose?
if _snowman is not considered appropriate then what about _ie_encoding_hint or something similar?
that would also help "the lost soul" figuring out what the f* is going on

@davout
Copy link

@davout davout commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving "_e" as a request parameter would make me feel like i regressed back to dotnet

@ncr
Copy link
Contributor

@ncr ncr commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave snowman alone! but seriously _ie_encoding_hint would be better than enigmatic _e

@samgranieri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the deal with the snowman?

@qoobaa
Copy link
Contributor

@qoobaa qoobaa commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncr: what a waste! _e param saves 6 bytes of memory... in every single form in the app!

@rubys
Copy link
Contributor

@rubys rubys commented on 7171161 Aug 10, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tossing this out there as something that might restore a bit of fun, while remaining functional, and being eminently searchable...


          snowman_tag = tag(:input, :type => "hidden",
                            :name => "8-&#x025f;&#x0287;n".html_safe,
                            :value => "&#x0183;&#x0131;po&#x0254;u&#x01dd;".html_safe)

http://tinyurl.com/2czkp49

@locriani
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want my snowman! If anything, though, _ie_encoding_hint, not _e.

Please sign in to comment.