All 2xx requests are considered successful [#217 state:resolved]

rails · Jul 17, 2008 · cd63015 · cd63015
1 parent f7fdbae
commit cd63015
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG
@@ -1,5 +1,7 @@
 *Edge*
 
+* All 2xx requests are considered successful [Josh Peek]
+
 * Fixed that AssetTagHelper#compute_public_path shouldn't cache the asset_host along with the source or per-request proc's won't run [DHH]
 
 * Removed config.action_view.cache_template_loading, use config.cache_classes instead [Josh Peek]

diff --git a/actionpack/lib/action_controller/test_process.rb b/actionpack/lib/action_controller/test_process.rb
@@ -171,7 +171,7 @@ def message
 
     # Was the response successful?
     def success?
-      response_code == 200
+      (200..299).include?(response_code)
     end
 
     # Was the URL not found?