Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add diff mode #617

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add diff mode #617

wants to merge 14 commits into from

Conversation

riccardoperra
Copy link
Owner

No description provided.

@riccardoperra riccardoperra linked an issue Jan 3, 2024 that may be closed by this pull request
Copy link

codesandbox bot commented Jan 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jan 3, 2024

⚠️ No Changeset found

Latest commit: dd119a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Deploy preview for codeimage-highlight-dev ready!

✅ Preview
https://codeimage-highlight-q33ixp8fu-riccardo-perras-projects.vercel.app
https://codeimage-highlight-pr-617.vercel.app

Built with commit dd119a6.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Deploy preview for codeimage-website-dev ready!

✅ Preview
https://codeimage-website-nxvyrrhvg-riccardo-perras-projects.vercel.app
https://codeimage-website-pr-617.vercel.app

Built with commit dd119a6.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-boykd9oja-riccardo-perras-projects.vercel.app
https://codeimage-app-pr-617.vercel.app

Built with commit dd119a6.
This pull request is being automatically deployed with vercel-action

@@ -245,6 +278,7 @@ export function createEditorsStore() {
languageId: editor.languageId,
id: editor.id,
code: editor.code,
metadata: editor.metadata,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be added in BE in order to don't break ts

Comment on lines +126 to +128
): DecorationSet {
console.log('from json');
const builder = new RangeSetBuilder<Decoration>();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
): DecorationSet {
console.log('from json');
const builder = new RangeSetBuilder<Decoration>();
): DecorationSet {
const builder = new RangeSetBuilder<Decoration>();

Copy link

stale bot commented Mar 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 4, 2024
@stale stale bot closed this Mar 12, 2024
@riccardoperra riccardoperra reopened this Apr 15, 2024
@stale stale bot removed the wontfix This will not be worked on label Apr 15, 2024
@riccardoperra riccardoperra changed the base branch from main to feat/git-diff-mode-syntax-highlight April 21, 2024 09:00
@riccardoperra riccardoperra changed the base branch from feat/git-diff-mode-syntax-highlight to main April 21, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Diff style
1 participant