Stop using old-style simd_shuffle
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebzulawski
approved these changes
Jul 10, 2023
|
Will be landing #352 first. |
|
@oli-obk In the newly-introduced CI, the toolchain is pinned to a specific nightly. This PR should probably unpin it, unless there's some other inscrutable compiler error barring that. Note that I am happy to call this "passing" CI if we still have 26 successes and 7 failures on CI. |
|
how the fuck was that legal |
|
...hmm. |
|
I swear I am going to set this repo on fire. |
|
CI why are you like this. |
|
Ah there we go. |
It is currently tracked separately from rust-toolchain.toml
workingjubilee
force-pushed
the
old_style_simd
branch
from
64dfa4b
to
c6a25c5
Compare
|
Thank you! I will try to land some more CI fixes/PRs and then cut 3.9 soon! |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 4, 2023
…workingjubilee Forbid old-style `simd_shuffleN` intrinsics Don't merge before rust-lang/packed_simd#350 has made its way to crates.io We used to support specifying the lane length of simd_shuffle ops by attaching the lane length to the name of the intrinsic (like `simd_shuffle16`). After this PR, you cannot do that anymore, and need to instead either rely on inference of the `idx` argument type or specify it as `simd_shuffle::<_, [u32; 16], _>`. r? `@workingjubilee`
This was referenced Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while fixing rust-lang/rust#113500 (this PR is not necessary, but will allow us to make the compiler simpler)