Forbid old-style simd_shuffleN intrinsics
#113534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @workingjubilee (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
oli-obk
force-pushed
the
simd_shuffle_dehackify
branch
from
d89f9da
to
e4646f0
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Jul 10, 2023
oli-obk
force-pushed
the
simd_shuffle_dehackify
branch
from
e4646f0
to
e4aac8b
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
simd_shuffle_dehackify
branch
2 times, most recently
from
b2dfecb
to
dffb486
Compare
|
☔ The latest upstream changes (presumably #113877) made this pull request unmergeable. Please resolve the merge conflicts. |
|
You may carry out the sentence. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
oli-obk
force-pushed
the
simd_shuffle_dehackify
branch
from
dffb486
to
4457ef2
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Hell yeah. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113534 (Forbid old-style `simd_shuffleN` intrinsics) - rust-lang#113999 (Specify macro is invalid in certain contexts) - rust-lang#114348 (Migrate GUI colors test to original CSS color format) - rust-lang#114373 (unix/kernel_copy.rs: copy_file_range_candidate allows empty output files) - rust-lang#114404 (Migrate GUI colors test to original CSS color format) - rust-lang#114409 (builtin impl confirmation wuhu) - rust-lang#114429 (compiletest: Handle non-utf8 paths (fix FIXME)) - rust-lang#114431 (Enable tests on rustc_codegen_ssa) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge before rust-lang/packed_simd#350 has made its way to crates.io
We used to support specifying the lane length of simd_shuffle ops by attaching the lane length to the name of the intrinsic (like
simd_shuffle16). After this PR, you cannot do that anymore, and need to instead either rely on inference of theidxargument type or specify it assimd_shuffle::<_, [u32; 16], _>.r? @workingjubilee