Add support for musl wheels #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please don't touch unrelated files |
|
OK, I'll let you fix those yourself. |
|
is this image official? I can't find any docs for it |
|
It's official. It was added in pypa/manylinux#1135. |
|
it's undocumented so I would prefer to wait until the linked issue there is resolved before depending on undocumented behavior |
|
So, it's fine to depend on a deprecated image ( |
|
The "undocumented" image is already used by pypa/cibuildwheel. There's really no reason not to depend on it. |
ObserverOfTime
force-pushed
the
musl
branch
2 times, most recently
from
3679ff2
to
c384c31
Compare
|
Would you accept a pull request that builds the wheels with cibuildwheel on GitHub actions instead? |
|
I'll take that as a no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #391. I've tested the musl wheel on Alpine edge and it works.
It might be worth creating a new release if and when this PR is merged.Both this change and the Python 2 removal (d333e3c) are quite important.