Add image for musllinux_1_1 #1135

lkollar · 2021-07-12T21:47:08Z

Closes: #1134

.github/workflows/build.yml

docker/build_scripts/build-git.sh

docker/build_scripts/finalize.sh

docker/build_scripts/install-entrypoint.sh

mayeut · 2021-07-18T17:22:47Z

Thanks for working on this @lkollar !
It looks promising.

lkollar · 2021-07-22T19:21:17Z

@mayeut this is ready. I've pushed the changes as fixups and new commits to make it easier to review.

mayeut · 2021-07-24T09:25:26Z

@lkollar,

I reworked the way python tools are installed (auditwheel & cmake).
Can you rebase please ?
I can do it if you prefer or don't have time.
Ideally I'd like to see 2 commits overall:

1st commit musllinux addition as if cmake python distribution was available
2nd commit with cmake installation workaround (this will allow to revert that commit easily once cmake is available for musllinux on PyPI)

Thanks

docker/build_scripts/update-system-packages.sh

mayeut · 2021-07-26T05:42:27Z

The requirements-*.in files have no reason to change now.
Other than that, we need to go forward with auditwheel before this can be merged.
I published some images based on this PR in order to test auditwheel pypa/auditwheel#315 & cibuildwheel pypa/cibuildwheel#768

lkollar · 2021-07-26T19:36:56Z

3c39866 adds the workaround for CMake. I've also added a separate commit to skip the auditwheel test on musllinux and make sure that the rest of the tests run fine. I'll try to wrap up the work on auditwheel next.

docker/build_scripts/install-libxcrypt.sh

docker/build_scripts/install-pypy.sh

docker/build_scripts/install-runtime-packages.sh

docker/build_scripts/update-system-packages.sh

mayeut · 2021-07-26T21:57:54Z

I added some more suggestions for cases that seems really dependent on musl vs glibc rather than a specific image version.
I did not add the suggestion for the workarounds which will hopefully disappear soon.

@lkollar, can you revert to draft while waiting for an auditwheel update please ?

As I see it, auditwheel will get released before the image. This PR will then be rebased and the workaround on auditwheel dropped.

docker/build_scripts/install-libxcrypt.sh

docker/Dockerfile

mayeut · 2021-09-18T13:21:13Z

There's an unrelated issue with arm64 builds on Travis CI. I will investigate this.

The image is based on Alpine Linux 3.12.

There are no wheels for CMake on musllinux and since it takes a long time to build it from source, we can instead install it with the OS package manager until wheels are available.

mayeut · 2021-09-18T20:08:50Z

We'll need to add some docs but for now, I'm merging this.
Thanks @lkollar, @liath

alex · 2021-09-18T20:18:56Z

🎉 are there any steps required before the images are uploaded to quay.io?

mayeut · 2021-09-18T20:23:02Z

@alex,

once the CI build is finished on master, images should be available on quay.io
There's already an issue with the i686 image (random network failure). I'll restart the build once everything else is built (I hope I setup quay.io properly otherwise I'll have to redo that).

alex · 2021-09-18T20:25:36Z

Thanks!

…

On Sat, Sep 18, 2021 at 4:23 PM Matthieu Darbois ***@***.***> wrote: @alex <https://github.com/alex>, once the CI build is finished on master, images should be available on quay.io There's already an issue with the i686 image (random network failure). I'll restart the build once everything else is built (I hope I setup quay.io properly otherwise I'll have to redo that). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1135 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBAPT3DCJFI76L5E5J3UCTYLBANCNFSM5AHVZJWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- All that is necessary for evil to succeed is for good people to do nothing.

hugovk · 2021-09-20T08:27:44Z

Thanks for this!

Should musllinux_1_1 also be documented in the README?

mayeut · 2021-09-20T10:28:11Z

@hugovk, yes, c.f. #1135 (comment)

docker/build_scripts/install-runtime-packages.sh

@@ -28,6 +31,8 @@ if [ "${AUDITWHEEL_POLICY}" == "manylinux2010" ] || [ "${AUDITWHEEL_POLICY}" ==
 	MANYLINUX_DEPS="glibc-devel libstdc++-devel glib2-devel libX11-devel libXext-devel libXrender-devel mesa-libGL-devel libICE-devel libSM-devel"
 elif [ "${AUDITWHEEL_POLICY}" == "manylinux_2_24" ]; then
 	MANYLINUX_DEPS="libc6-dev libstdc++-6-dev libglib2.0-dev libx11-dev libxext-dev libxrender-dev libgl1-mesa-dev libice-dev libsm-dev"
+elif [ "${AUDITWHEEL_POLICY}" == "musllinux_1_1" ]; then
+	MANYLINUX_DEPS="musl-dev libstdc++ glib-dev libx11-dev libxext-dev libxrender-dev mesa-dev libice-dev libsm-dev"


lkollar self-assigned this Jul 12, 2021

lkollar force-pushed the musl branch 2 times, most recently from abec629 to 61bcb8e Compare July 15, 2021 22:06