We don't have length/thickness under Product #1339
Conversation
We need to clarify that depth is also known as thickness. In expanded form of the depth description, we could even say 'the depth or thickness or length of the item'. But this begs the question of how not to confuse thickness with height In general terms, its left/right, front/backtop/bottom. In the States, we typically express those same general term of a Products' dimensions as length/width/height .. but for Product we currently have depth/width/height. I think for developers, that causes more harm than good in trying to align with those general terms.
|
/cc @mfhepp - any thoughts? |
|
Hmm. We already have properties for three dimensions. The naming might be suboptimal for some cases and straightforward for others. I see two options:
I tend to recommend #2 because a clean model for 3D shapes will be quite some effort and likely hard to populate from existing databases. Martin martin hepp http://www.heppnetz.de
|
|
+1 on using 2 , the use of additionalProperty with some good examples. |
|
ok where are we with this? is the proposal to just updated the description? What about the mention of additionalProperty? /cc @vholland @nicolastorzec @scor @rvguha @tilid @tmarshbing |
|
(we're also btw now committing changes direct to master branch, so any PR will need to be targetted there, sorry for the administrivia) |
|
This and issue #544 about Product quantity seemed to split our collective energy. I am not sure if we should try to merge them under one issue or just be aware there are two. |
We need to clarify that depth is also known as thickness.
In expanded form of the depth description, we could even say 'the depth or thickness or length of the item'. But this begs the question of how not to confuse thickness with height
In general terms, its left/right, front/back, top/bottom.
In the States, we typically express those same general terms of a Products' dimensions as length/width/height .. but for Product we currently have depth/width/height. I think for developers, that causes more harm than good in trying to align with those general terms.
Proposal:
Also found in the complaint #528 Product dimensions should be length x width x height