Skip to content

Commit

Permalink
Auto merge of #21826 - servo:jdm-patch-35, r=jdm
Browse files Browse the repository at this point in the history
Enable fake fillText API in nightly builds.

The [three.js examples](https://threejs.org/examples/) are really useful for checking Servo WebGL support, but if the fillText API is not available they only display a blank screen. I think it's worth lying to web content about this API in order to make it easy to make use of these examples without using local development builds.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21826)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Oct 2, 2018
2 parents 57053e0 + c3c8aab commit 74ba683
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 19 deletions.
2 changes: 1 addition & 1 deletion resources/prefs.json
@@ -1,7 +1,7 @@
{
"dom.bluetooth.enabled": false,
"dom.bluetooth.testing.enabled": false,
"dom.canvas-text.enabled": false,
"dom.canvas-text.enabled": true,
"dom.compositionevent.enabled": false,
"dom.customelements.enabled": true,
"dom.forcetouch.enabled": false,
Expand Down
1 change: 1 addition & 0 deletions tests/wpt/metadata/2dcontext/__dir__.ini
@@ -0,0 +1 @@
prefs: ["dom.canvas-text.enabled:false"]
18 changes: 0 additions & 18 deletions tests/wpt/metadata/html/dom/interfaces.https.html.ini
Expand Up @@ -4259,9 +4259,6 @@
[CanvasRenderingContext2D interface: operation scrollPathIntoView(Path2D)]
expected: FAIL

[CanvasRenderingContext2D interface: operation fillText(DOMString, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL

[CanvasRenderingContext2D interface: operation strokeText(DOMString, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL

Expand Down Expand Up @@ -4334,12 +4331,6 @@
[CanvasRenderingContext2D interface: calling scrollPathIntoView(Path2D) on document.createElement("canvas").getContext("2d") with too few arguments must throw TypeError]
expected: FAIL

[CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "fillText(DOMString, unrestricted double, unrestricted double, unrestricted double)" with the proper type]
expected: FAIL

[CanvasRenderingContext2D interface: calling fillText(DOMString, unrestricted double, unrestricted double, unrestricted double) on document.createElement("canvas").getContext("2d") with too few arguments must throw TypeError]
expected: FAIL

[CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "strokeText(DOMString, unrestricted double, unrestricted double, unrestricted double)" with the proper type]
expected: FAIL

Expand Down Expand Up @@ -10292,9 +10283,6 @@
[CanvasRenderingContext2D interface: operation scrollPathIntoView(Path2D)]
expected: FAIL

[CanvasRenderingContext2D interface: operation fillText(DOMString, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL

[CanvasRenderingContext2D interface: operation strokeText(DOMString, unrestricted double, unrestricted double, unrestricted double)]
expected: FAIL

Expand Down Expand Up @@ -10367,12 +10355,6 @@
[CanvasRenderingContext2D interface: calling scrollPathIntoView(Path2D) on document.createElement("canvas").getContext("2d") with too few arguments must throw TypeError]
expected: FAIL

[CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "fillText(DOMString, unrestricted double, unrestricted double, unrestricted double)" with the proper type]
expected: FAIL

[CanvasRenderingContext2D interface: calling fillText(DOMString, unrestricted double, unrestricted double, unrestricted double) on document.createElement("canvas").getContext("2d") with too few arguments must throw TypeError]
expected: FAIL

[CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "strokeText(DOMString, unrestricted double, unrestricted double, unrestricted double)" with the proper type]
expected: FAIL

Expand Down

0 comments on commit 74ba683

Please sign in to comment.