Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #16861 - gterzian:use_microtask_to_await_stable_state, …
…r=jdm Use microtasks to await a stable state. <!-- Please describe your changes on the following line: --> @jdm @KiChjang First pass at using microtasks to await a stable state. I ran into all sorts of problems to get it to compile, I think it's mainly related to the fact that the microtasks are stored in a `Vec`, which meant the `Runnalbe.handler(self: Box<Self>)` couldn't be called while iterating over the Vec... It compiles now although I haven't run any tests. I'm assuming I'm missing something fundamental and was hoping my changes would highlight the problems I run into, and you had a better idea of how to implement this... Perhaps we shouldn't pass a `Runnable` to `await_stable_state` at all? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #15375 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16861) <!-- Reviewable:end -->
- Loading branch information
Showing
12 changed files
with
47 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 0 additions & 5 deletions
5
...edia-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...content/media-elements/loading-the-media-resource/resource-selection-invoke-load.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...elements/loading-the-media-resource/resource-selection-invoke-pause-networkState.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...ontent/media-elements/loading-the-media-resource/resource-selection-invoke-pause.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...content/media-elements/loading-the-media-resource/resource-selection-invoke-play.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...g-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...nts/loading-the-media-resource/resource-selection-invoke-set-src-not-in-document.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...tent/media-elements/loading-the-media-resource/resource-selection-invoke-set-src.html.ini
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...-content/media-elements/loading-the-media-resource/resource-selection-remove-src.html.ini
This file was deleted.
Oops, something went wrong.