Make the WebSocket handshake ourselves 🍷 #16180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
r? @jdm |
jdm
previously requested changes
Mar 29, 2017
components/net/websocket_loader.rs
Outdated
| let secure = match url.scheme() { | ||
| "ws" => false, | ||
| "wss" => true, | ||
| _ => panic!("URL's scheme should be http or https"), |
components/net/websocket_loader.rs
Outdated
| // Step 14.6. | ||
| let protocol_in_use = if let Some(response_protocols) = response.headers.get::<WebSocketProtocol>() { | ||
| for p in &**response_protocols { | ||
| if !protocols.contains(p) { |
There was a problem hiding this comment.
The previous check used eq_ignore_ascii_case. Is this the cause of the new test failure?
jdm
added
S-needs-code-changes
We need to switch to tungstenite to finally update openssl, this commit rewrites the whole websocket infrastructure to properly follow the Fetch spec and to make switching to a different websocket library easier.
highfive
added
S-awaiting-review
|
@bors-servo: r+ |
|
📌 Commit d022535 has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo p=17 |
bors-servo
pushed a commit
that referenced
this pull request
Mar 29, 2017
Make the WebSocket handshake ourselves 🍷 HYPE <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16180) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HYPE
This change is