Implement webkit-prefixed linear gradients #16440
Conversation
|
|
highfive
added
the
S-awaiting-review
|
r? @upsuper |
| if input.try(|input| input.expect_ident_matching("to")).is_ok() { | ||
| impl AngleOrCorner { | ||
| fn parse(context: &ParserContext, input: &mut Parser, mode: CompatMode) -> Result<Self, ()> { | ||
| if let Ok(angle) = input.try(|i| Angle::parse(context, i)) { |
There was a problem hiding this comment.
This needs to allow unitless angles for webkit gradients (and for all non-moz gradients, actually)
There was a problem hiding this comment.
AFAIK the same is true for non-webkit gradients and thus is a bit unrelated to that change.
There was a problem hiding this comment.
Sounds fine, feel free to do it as a followup or file an issue (though given it's just s/Angle::parse/Angle::parse_with_unitless thought it may be worth to just do it here).
|
r? @emilio |
| if input.try(|input| input.expect_ident_matching("to")).is_ok() { | ||
| impl AngleOrCorner { | ||
| fn parse(context: &ParserContext, input: &mut Parser, mode: CompatMode) -> Result<Self, ()> { | ||
| if let Ok(angle) = input.try(|i| Angle::parse(context, i)) { |
There was a problem hiding this comment.
Sounds fine, feel free to do it as a followup or file an issue (though given it's just s/Angle::parse/Angle::parse_with_unitless thought it may be worth to just do it here).
|
@bors-servo r+ |
|
📌 Commit ba3f18f has been approved by |
highfive
added
S-awaiting-merge
Implement webkit-prefixed linear gradients This is half of #15441. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16440) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
This is half of #15441.
This change is