New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement webkit-prefixed linear gradients #16440
Conversation
r? @upsuper |
if input.try(|input| input.expect_ident_matching("to")).is_ok() { | ||
impl AngleOrCorner { | ||
fn parse(context: &ParserContext, input: &mut Parser, mode: CompatMode) -> Result<Self, ()> { | ||
if let Ok(angle) = input.try(|i| Angle::parse(context, i)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to allow unitless angles for webkit gradients (and for all non-moz gradients, actually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the same is true for non-webkit gradients and thus is a bit unrelated to that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine, feel free to do it as a followup or file an issue (though given it's just s/Angle::parse/Angle::parse_with_unitless
thought it may be worth to just do it here).
r? @emilio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with that or with an issue filled
Thanks!
if input.try(|input| input.expect_ident_matching("to")).is_ok() { | ||
impl AngleOrCorner { | ||
fn parse(context: &ParserContext, input: &mut Parser, mode: CompatMode) -> Result<Self, ()> { | ||
if let Ok(angle) = input.try(|i| Angle::parse(context, i)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine, feel free to do it as a followup or file an issue (though given it's just s/Angle::parse/Angle::parse_with_unitless
thought it may be worth to just do it here).
@bors-servo r+ |
📌 Commit ba3f18f has been approved by |
Implement webkit-prefixed linear gradients This is half of #15441. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16440) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
This is half of #15441.
This change is