Implemented paint worklets drawing to a border. #17862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asajeffrey
added
A-content/css
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
asajeffrey
force-pushed
the
script-paint-worklet-border
branch
from
437d785
to
26598d2
Compare
|
☔ The latest upstream changes (presumably #17810) made this pull request unmergeable. Please resolve the merge conflicts. |
asajeffrey
force-pushed
the
script-paint-worklet-border
branch
from
26598d2
to
c95d2e5
Compare
pcwalton
reviewed
Aug 7, 2017
| &clip, | ||
| paint_worklet, | ||
| i); | ||
| let size = self.border_box - style.logical_border_width(); |
There was a problem hiding this comment.
(Isn't there a content_box() method for this?)
There was a problem hiding this comment.
The content_box method doesn't include the padding though.
|
☔ The latest upstream changes (presumably #17845) made this pull request unmergeable. Please resolve the merge conflicts. |
asajeffrey
force-pushed
the
script-paint-worklet-border
branch
from
c95d2e5
to
3f71be7
Compare
|
@pcwalton ping? |
|
@bors-servo: r+ |
|
📌 Commit 3f71be7 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Sep 18, 2017
…lton Implemented paint worklets drawing to a border. <!-- Please describe your changes on the following line: --> Allow paint worklets to draw to a border. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17451. - [X] These changes do not require tests because the existing css-paint-api test check this (but annoyingly, all fail for other reasons) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17862) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
|
@pcwalton: thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow paint worklets to draw to a border.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is