Implement instanced WebGL drawing calls (part of #20791) #21129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
r? @emilio |
bors-servo
pushed a commit
that referenced
this pull request
Jul 6, 2018
Correctly implement the vertex buffer checks in drawArrays This is half of #20599. The check for drawElements is a bit more complex to implement.
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
Manishearth
approved these changes
Jul 6, 2018
nox
force-pushed
the
webgl
branch
3 times, most recently
from
97f7fc1
to
578d3f2
Compare
nox
changed the title
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Jul 7, 2018
Implement instanced WebGL drawing calls (part of #20791) This is half of #20599. The check for drawElements is a bit more complex to implement. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21129) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt3 |
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Jul 7, 2018
Implement instanced WebGL drawing calls (part of #20791) This is half of #20599. The check for drawElements is a bit more complex to implement. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21129) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-css |
|
@bors-servo try |
It only returns null if there was an error, and the only error isn't implemented yet.
gl.getProgramInfoLog was implemented a while back.
They don't seem flaky anymore and we have a tool to properly keep intermittent results anyway now.
This is half of #20599. The check for drawElements is a bit more complex to implement.
highfive
added
S-awaiting-review
|
@bors-servo r=emilio |
|
📌 Commit 4e6eea2 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 8, 2018
Implement instanced WebGL drawing calls (part of #20791) This is half of #20599. The check for drawElements is a bit more complex to implement. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21129) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
|
@bors-servo retry #21067 #20734 |
|
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt1... |
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is half of #20599. The check for drawElements is a bit more complex to implement.
This change is