Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gl.getUniform() #21202

Merged
merged 3 commits into from Jul 18, 2018
Merged

Implement gl.getUniform() #21202

merged 3 commits into from Jul 18, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Jul 18, 2018 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl, components/script/dom/webgl2renderingcontext.rs
  • @paulrouget: components/compositing/Cargo.toml, components/servo/Cargo.toml, ports/servo/Cargo.toml
  • @KiChjang: components/script/Cargo.toml, components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl, components/script/dom/webgl2renderingcontext.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 18, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@jdm
Copy link
Member

jdm commented Jul 18, 2018

@bors-servo r+
Nice use of generics to make the implementation readable!

@bors-servo
Copy link
Contributor

📌 Commit 37e9f7e has been approved by jdm

@highfive highfive assigned jdm and unassigned emilio Jul 18, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 18, 2018
@jdm jdm mentioned this pull request Jul 18, 2018
Closed
4 tasks
@bors-servo
Copy link
Contributor

⌛ Testing commit 37e9f7e with merge d404085...

bors-servo pushed a commit that referenced this pull request Jul 18, 2018
Auto merge of #21202 - servo:webgl, r=jdm
d404085 
Implement gl.getUniform()

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21202)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 18, 2018
@jdm
Copy link
Member

jdm commented Jul 18, 2018

@bors-servo retry

  • the failed machine was in use

@bors-servo
Copy link
Contributor

⌛ Testing commit 37e9f7e with merge 41e6b11...

bors-servo pushed a commit that referenced this pull request Jul 18, 2018
Auto merge of #21202 - servo:webgl, r=jdm
41e6b11 
Implement gl.getUniform()

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21202)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 18, 2018
@emilio emilio mentioned this pull request Jul 18, 2018
Open
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 18, 2018
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jul 18, 2018
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 18, 2018
@nox
Copy link
Contributor Author

nox commented Jul 18, 2018

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

📌 Commit 3e8c2d6 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 18, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 3e8c2d6 with merge 40ce549...

bors-servo pushed a commit that referenced this pull request Jul 18, 2018
Auto merge of #21202 - servo:webgl, r=jdm
40ce549 
Implement gl.getUniform()

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21202)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - android-x86

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 18, 2018
@jdm
Copy link
Member

jdm commented Jul 18, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 3e8c2d6 with merge 448ce0c...

bors-servo pushed a commit that referenced this pull request Jul 18, 2018
Auto merge of #21202 - servo:webgl, r=jdm
448ce0c 
Implement gl.getUniform()

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21202)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 18, 2018
@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 448ce0c to master...

@bors-servo bors-servo merged commit 3e8c2d6 into master Jul 18, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 18, 2018
This was referenced Jul 18, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @jdm @bors-servo @emilio