Added support for Digitech QM1576 serial protocol parser The protocol #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is described at https://www.airspayce.com/mikem/QM1578/protocol.txt You can use this decoder with libsigrok and Digitech QM1578 via ESP32 Bluetooth-Serial converter available from the author at: https://www.airspayce.com/mikem/QM1578/QM1578BluetoothClient.ino which connects to the QM1578 over Bluetooth LE, fetches the data stream and sends it on the serial port to the host, where this driver can read it with this command for example: sigrok-cli --driver digitech-qm1578:conn=/dev/ttyUSB1 --continuous
acassis
reviewed
Jun 28, 2022
src/dmm/qm1578.c
Outdated
| case 0x05: return -3; /* For amps */ | ||
| case 0x06: return -3; /* For volts */ | ||
| default: | ||
| sr_dbg("Unknown multiplier: 0x%02x.", buf[11]); |
There was a problem hiding this comment.
Please indent your code, more info: https://www2.cs.arizona.edu/~mccann/indent_c.html
src/dmm/qm1578.c
Outdated
|
|
||
| /* On overload, digits 4 to 1 are: 0x0b 0x0a 0x00 0x0b */ | ||
| if (buf[8] == 0x0b) | ||
| return INFINITY; |
src/dmm/qm1578.c
Outdated
Comment on lines
82
to
85
| digit = buf[8 - i]; | ||
| if (digit < 0 || digit > 9) | ||
| continue; | ||
| val = 10.0 * val + digit; |
There was a problem hiding this comment.
Add indent to indicate this board in inside the for loop
src/dmm/qm1578.c
Outdated
| * and just use the presence of the trailing record separator | ||
| */ | ||
| if (buf[14] != 0x0d) | ||
| return FALSE; |
src/dmm/qm1578.c
Outdated
Comment on lines
121
to
136
| if (buf[13] & 0x10) | ||
| analog->meaning->mqflags |= SR_MQFLAG_AUTORANGE; | ||
| if (buf[13] & 0x40) | ||
| analog->meaning->mqflags |= SR_MQFLAG_DC; | ||
| if (buf[13] & 0x80) | ||
| analog->meaning->mqflags |= SR_MQFLAG_AC; | ||
| if (buf[13] & 0x20) | ||
| analog->meaning->mqflags |= SR_MQFLAG_RELATIVE; | ||
| if (buf[12] & 0x40) | ||
| analog->meaning->mqflags |= SR_MQFLAG_HOLD; | ||
| if ((buf[13] & 0x0c) == 0x0c) | ||
| analog->meaning->mqflags |= SR_MQFLAG_MAX; | ||
| if ((buf[13] & 0x0c) == 0x08) | ||
| analog->meaning->mqflags |= SR_MQFLAG_MIN; | ||
| if ((buf[13] & 0x0c) == 0x0c) | ||
| analog->meaning->mqflags |= SR_MQFLAG_AVG; |
src/dmm/qm1578.c
Outdated
Comment on lines
172
to
174
| analog->meaning->mq = SR_MQ_CURRENT; | ||
| analog->meaning->unit = SR_UNIT_AMPERE; | ||
| analog->meaning->mqflags |= SR_MQFLAG_AC | SR_MQFLAG_RMS; |
src/dmm/qm1578.c
Outdated
Comment on lines
177
to
179
| analog->meaning->mq = SR_MQ_VOLTAGE; | ||
| analog->meaning->unit = SR_UNIT_VOLT; | ||
| analog->meaning->mqflags |= SR_MQFLAG_DIODE; |
src/dmm/qm1578.c
Outdated
Comment on lines
182
to
191
| if (buf[10] == 0x04) | ||
| { | ||
| analog->meaning->mq = SR_MQ_FREQUENCY; | ||
| analog->meaning->unit = SR_UNIT_HERTZ; | ||
| } | ||
| else | ||
| { | ||
| analog->meaning->mq = SR_MQ_DUTY_CYCLE; | ||
| analog->meaning->unit = SR_UNIT_PERCENTAGE; | ||
| } |
There was a problem hiding this comment.
ditto, you did it for internal if/else but forgot for external one
src/dmm/qm1578.c
Outdated
Comment on lines
194
to
195
| analog->meaning->mq = SR_MQ_CONTINUITY; | ||
| analog->meaning->unit = SR_UNIT_OHM; |
src/dmm/qm1578.c
Outdated
| val *= powf(10, exponent); | ||
|
|
||
| if (buf[12] & 0x80) | ||
| val = -val; |
|
Thanks for your review. |
Perfect! If you want please squash these commits, but I will already give an approval |
acassis
approved these changes
Jun 30, 2022
|
Thanks for your help and efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is described at https://www.airspayce.com/mikem/QM1578/protocol.txt
You can use this decoder with libsigrok and Digitech QM1578 via ESP32
Bluetooth-Serial converter available from the author at:
https://www.airspayce.com/mikem/QM1578/QM1578BluetoothClient.ino which
connects to the QM1578 over Bluetooth LE, fetches the data stream and
sends it on the serial port to the host, where this driver can read it
with this command for example:
sigrok-cli --driver digitech-qm1578:conn=/dev/ttyUSB1 --continuous