Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subsumption #2407

Merged
merged 4 commits into from Mar 27, 2023
Merged

Fix subsumption #2407

merged 4 commits into from Mar 27, 2023

Conversation

julienhenry
Copy link
Member

@julienhenry julienhenry commented Mar 10, 2023

I noticed a number of bugs when translating recursive subsumptive rules.

  • the @Reject clauses do not need to iterate on all versions of the rule: they must always use the concrete relations from the body.
  • the @delete clauses were not produced properly if the body of the subsumptive rules had atoms in the same scc. Some of the rules had multiple @delta relations, some other had none...

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #2407 (d13fbc8) into master (2914f7b) will increase coverage by 0.02%.
The diff coverage is 63.63%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2407      +/-   ##
==========================================
+ Coverage   77.75%   77.77%   +0.02%     
==========================================
  Files         474      474              
  Lines       31164    31164              
==========================================
+ Hits        24232    24239       +7     
+ Misses       6932     6925       -7     
Impacted Files Coverage Δ
src/include/souffle/utility/SubProcess.h 55.00% <0.00%> (ø)
src/MainDriver.cpp 70.39% <50.00%> (ø)
src/ast2ram/seminaive/UnitTranslator.cpp 94.40% <100.00%> (-0.02%) ⬇️
src/ast2ram/utility/Utils.cpp 77.61% <100.00%> (+0.33%) ⬆️

... and 3 files with indirect coverage changes

quentin
quentin previously approved these changes Mar 10, 2023
@quentin
Copy link
Member

quentin commented Mar 23, 2023

Hi Julien,
I made many attempts to fix the 2 tests that crash, and I could not find the reason for the crashes yet:

  • update vcpkg version
  • update sqlite3 version
  • synchronize sqlite3 version from vcpkg (headers) and chocolatey (dll / binaries)

It has to be something that changed in the last update of GitHub's Windows 2019 runner image.

I suggest we disable the 2 tests on Windows until we find a solution.

@julienhenry
Copy link
Member Author

Yes, I don't know how to fix that... I'm going to disable SQL on Windows for the CI and see if that works.

quentin
quentin previously approved these changes Mar 23, 2023
@julienhenry
Copy link
Member Author

Looks like it made things even worse...

@quentin quentin merged commit 314106d into souffle-lang:master Mar 27, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants