Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple selection support to SC.SelectView #1469

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add multiple selection support to SC.SelectView #1469

wants to merge 23 commits into from

Conversation

nicolasbadia
Copy link
Member

Adds allowsMultipleSelection and multipleSelectionName properties to SC.SelectView.

Requires #1443

nicolasbadia and others added 23 commits August 25, 2019 17:46
@nicolasbadia
Adds a convenience allowsMultipleSelection property
a98e320
@nicolasbadia
Adds a convenience allowsEmptySelection property
89d23c4
@nicolasbadia
Implements page moves in SC.CollectionView
2355fa5
@nicolasbadia
Adds support for isEnabled to SC.ContentValueSupport
03a4745
@nicolasbadia
Refactors SC.MenuPane to use SC.ListView internally
e49fdc3
@nicolasbadia
Adds itemUnreadCountKey support to SC.MenuPane
3a540ba
@nicolasbadia
Removes some useless CSS prefixes
f4db189
@nicolasbadia
Bunch of fixes and improvements for the experimental select views
453ad40
@nicolasbadia
Improves keyboard handling with SC.MenuPane
4d71559
@nicolasbadia
Initial work on an SC.ItemFormatter mixin to help generating displayI…
8bda9fd 
…tems
@nicolasbadia
Removes a useless and nasty observers
4b75b94 
Nasty because if unexpectedly update the value when the items changes.
@nicolasbadia
Updates SC.SelectView displayItems if the emptyName is updated
ca16c07
@nicolasbadia
Simplify items observers setup for the radio and select views
10f6c60 
Also fixes a memory leak on the radio view because the observers were never destroyed
@nicolasbadia
Fixes a wrong variable name
124600d
@nicolasbadia
Removes dead code
22223bc
@nicolasbadia
Improves select view title computation when a null value is selected
da82c15
@nicolasbadia
Fixes SC.MenuPane touch support
eeab926
@nicolasbadia
Prevent a crash if the title of a menu item is a number
0220ccf
@nicolasbadia
Prevent displaying the button as selected when the value is true
717a8a7
@nicolasbadia
Improves SC.SelectSearchView performances and extensibility
43e48ce
@nicolasbadia
Prevent an infinit loop with allowsMultipleSelection
15312a7
@nicolasbadia
Make use of the new computed property allowsMultipleSelection also in…
d2b38f6 
… mouse event listeners
Add multiple selection support to SC.SelectView
dc94d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nicolasbadia