Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for stripe-ruby v10 #893

Merged

Conversation

fabianoarruda
Copy link
Contributor

Fixed deprecated methods in specs:

  • Deprecate delete method on Subscription resource. Please use cancel method instead. (since v7)
  • Deprecated Recipient resource (since v7). Using customer object instead in Bank Account token test.
  • Upcoming Invoice raises Stripe::InvalidRequestError instead of ArgumentError if no argument is given.

- Fixed deprecated methods in specs
@fabianoarruda
Copy link
Contributor Author

I have pushed a small update for compatibility with the last version 10.5, but for some reason, GitHub actions are failing. Rspec tests are passing on my local env though.

@alexmamonchik
Copy link
Contributor

I have pushed a small update for compatibility with the last version 10.5, but for some reason, GitHub actions are failing. Rspec tests are passing on my local env though.

what ruby version do you use?

@fabianoarruda
Copy link
Contributor Author

what ruby version do you use?

I was running 2.6. I had to upgrade rspec to v3.12, and was able to run the tests with 2.7 and 3.0 too.

Checking workflow logs, it seems to be related with different versions of stripe ruby. I'll investigate further.

@fabianoarruda
Copy link
Contributor Author

Ok fixed the issue. Only 2.7 workflow failed with a single test, looks like a flaky test?

 1) StripeMock Server behaves like Customer Subscriptions with plans creating a new subscription sets current_period_end based on price week interval
     Failure/Error: expect(subscription.current_period_end).to eq (Time.now + (7 * 60 * 60 * 24)).to_i

       expected: 1705502858
            got: 1705502857

       (compared using ==)
     Shared Example Group: "Customer Subscriptions with plans" called from ./spec/support/stripe_examples.rb:36
     # ./spec/shared_stripe_examples/subscription_examples.rb:589:in `block (3 levels) in <top (required)>'

@alexmamonchik alexmamonchik changed the base branch from master to init-v4 February 10, 2024 09:09
@alexmamonchik
Copy link
Contributor

@fabianoarruda please, solve conflicts and we'll merge this PR into init-v4 branch. I would like to merge few another PRs with will be in v4 label, fix all failed tests and release 4.0.0 gem.

This was referenced Feb 10, 2024
@alexmamonchik alexmamonchik merged commit 1c616c1 into stripe-ruby-mock:init-v4 Feb 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants