-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for stripe-ruby v10 #893
Adds support for stripe-ruby v10 #893
Conversation
- Fixed deprecated methods in specs
2f0fbb8
to
b05c1b2
Compare
I have pushed a small update for compatibility with the last version 10.5, but for some reason, GitHub actions are failing. Rspec tests are passing on my local env though. |
what ruby version do you use? |
I was running 2.6. I had to upgrade rspec to v3.12, and was able to run the tests with 2.7 and 3.0 too. Checking workflow logs, it seems to be related with different versions of stripe ruby. I'll investigate further. |
Ok fixed the issue. Only 2.7 workflow failed with a single test, looks like a flaky test?
|
@fabianoarruda please, solve conflicts and we'll merge this PR into |
Fixed deprecated methods in specs:
delete
method onSubscription
resource. Please usecancel
method instead. (since v7)Recipient
resource (since v7). Using customer object instead in Bank Account token test.Stripe::InvalidRequestError
instead ofArgumentError
if no argument is given.