Skip to content

Commit

Permalink
bug #22752 Improved how profiler errors are displayed on small screen…
Browse files Browse the repository at this point in the history
…s (javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Improved how profiler errors are displayed on small screens

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This change only affects the profiler menu when displaying it on small screens and collapsed:

| BEFORE | AFTER
| --- | ---
| ![before](https://cloud.githubusercontent.com/assets/73419/26194914/483ad578-3bba-11e7-85bb-94f00876b89a.png) | ![after](https://cloud.githubusercontent.com/assets/73419/26194916/492598d8-3bba-11e7-8d7c-6f37a3b00098.png)

In action:

![profiler-menu-errors](https://cloud.githubusercontent.com/assets/73419/26194969/749e7a7a-3bba-11e7-9464-d3c75fa51315.gif)

Commits
-------

3d6d80d Improved how profiler errors are dispalyed on small screens
  • Loading branch information
fabpot committed May 18, 2017
2 parents b8c9597 + 3d6d80d commit 80e2e1f
Showing 1 changed file with 12 additions and 0 deletions.
Expand Up @@ -973,6 +973,18 @@ table.logs .sf-call-stack abbr {
display: block;
}

#sidebar:not(:hover):not(.expanded) .label .count {
border-radius: 50%;
border: 1px solid #eee;
height: 8px;
min-width: 0;
padding: 0;
right: 4px;
text-indent: -9999px;
top: 50%;
width: 8px;
}

.visible-small {
display: inherit;
}
Expand Down

0 comments on commit 80e2e1f

Please sign in to comment.