New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved how profiler errors are displayed on small screens #22752

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
5 participants
@javiereguiluz
Member

javiereguiluz commented May 18, 2017

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This change only affects the profiler menu when displaying it on small screens and collapsed:

BEFORE AFTER
before after

In action:

profiler-menu-errors

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone May 18, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 18, 2017

Member

Thank you @javiereguiluz.

Member

fabpot commented May 18, 2017

Thank you @javiereguiluz.

@fabpot fabpot merged commit 3d6d80d into symfony:2.8 May 18, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 18, 2017

bug #22752 Improved how profiler errors are displayed on small screen…
…s (javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Improved how profiler errors are displayed on small screens

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This change only affects the profiler menu when displaying it on small screens and collapsed:

| BEFORE | AFTER
| --- | ---
| ![before](https://cloud.githubusercontent.com/assets/73419/26194914/483ad578-3bba-11e7-85bb-94f00876b89a.png) | ![after](https://cloud.githubusercontent.com/assets/73419/26194916/492598d8-3bba-11e7-8d7c-6f37a3b00098.png)

In action:

![profiler-menu-errors](https://cloud.githubusercontent.com/assets/73419/26194969/749e7a7a-3bba-11e7-9464-d3c75fa51315.gif)

Commits
-------

3d6d80d Improved how profiler errors are dispalyed on small screens

This was referenced May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment