Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #17748 [DomCrawler] Remove the overridden getHash() method to pre…
…vent problems when cloning the crawler (jakzal) This PR was merged into the 2.8 branch. Discussion ---------- [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16421 | License | MIT | Doc PR | - Overriding the `SplObjectStorage::getHash()` is affected by a [PHP bug](https://bugs.php.net/bug.php?id=67582), which makes the Crawler unusable in Symfony 2.8 for anyone who relied on `SplObjectStorage` methods. Removing the `getHash()` method means we will no longer trigger the deprecation error. Given this method is unlikely to be used directly and other `SplObjectStorage` methods will trigger the error, it is the simplest thing we can do to maintain BC. Commits ------- 3d7f6c6 [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler
- Loading branch information