[DomCrawler] Cloned Crawler objects not usable because of overwritten getHash method #16421
Labels
Comments
|
@wasinger can you give me an example how to reproduce this behaviour? |
|
Here is how to reproduce it: use Symfony\Component\DomCrawler\Crawler;
$c = new Crawler('<html><head></head><body>Some HTML code</body></html>');
echo "Crawler has " . count($c) . " Elements\n"; // 1
$c1 = clone $c;
echo "Cloned Crawler has " . count($c1) . " Elements\n"; // 1
// Remove first node from Crawler
$c->detach($c->getNode(0));
echo "Crawler has " . count($c) . " Elements\n"; // 0
// Remove first node from cloned Crawler
$c1->detach($c1->getNode(0));
echo "Cloned Crawler has " . count($c1) . " Elements\n"; // Should be: 0, sf 2.7: 0, sf 2.8: 1The last line prints "1" in Symfony 2.8 while it should be 0. |
|
Options I see here:
|
|
I suggest going for the second option |
|
Ok. I'll send a PR soon. |
jakzal
added a commit
that referenced
this issue
Feb 10, 2016
…vent problems when cloning the crawler (jakzal) This PR was merged into the 2.8 branch. Discussion ---------- [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16421 | License | MIT | Doc PR | - Overriding the `SplObjectStorage::getHash()` is affected by a [PHP bug](https://bugs.php.net/bug.php?id=67582), which makes the Crawler unusable in Symfony 2.8 for anyone who relied on `SplObjectStorage` methods. Removing the `getHash()` method means we will no longer trigger the deprecation error. Given this method is unlikely to be used directly and other `SplObjectStorage` methods will trigger the error, it is the simplest thing we can do to maintain BC. Commits ------- 3d7f6c6 [DomCrawler] Remove the overridden getHash() method to prevent problems when cloning the crawler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since 2.8, DomCrawler overrides the SplStorage method "getHash($object)" for the purpose of displaying a deprecation message.
When a Crawler object is cloned this triggers PHP Bug #67582 Cloned SplObjectStorage with overwritten getHash fails offsetExists() and makes the cloned Crawler instance not working correctly (e.g. it's not possible to remove elements from them because methods detach() and removeAll() don't work).
Removing elements from cloned Crawler instances was not a problem up to Symfony 2.7. It's a regression that breaks some of my projects.
The problem was introduced in commit 997c650
The text was updated successfully, but these errors were encountered: