Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor #18939 [FrameworkBundle] Skip redis cache pools test on failed …
…connection (chalasr) This PR was squashed before being merged into the 3.1 branch (closes #18939). Discussion ---------- [FrameworkBundle] Skip redis cache pools test on failed connection | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Actually, running the FrameworkBundle tests suit leads to a failure that says: > 1) Symfony\Bundle\FrameworkBundle\Tests\Functional\CachePoolsTest::testRedisCachePools Symfony\Component\Cache\Exception\InvalidArgumentException: Redis connection failed: redis://localhost [...] [...]/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php:59 [...]/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php:30 So I propose to catch this specific exception in case of redis is not (locally) supported, in order to be sure that tests stay green. Commits ------- 0d349dd [FrameworkBundle] Skip redis cache pools test on failed connection
- Loading branch information