[FrameworkBundle] Skip redis cache pools test on failed connection

[chalasr]

Q	A
Branch?	3.1
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Actually, running the FrameworkBundle tests suit leads to a failure that says:

1. Symfony\Bundle\FrameworkBundle\Tests\Functional\CachePoolsTest::testRedisCachePools
   Symfony\Component\Cache\Exception\InvalidArgumentException: Redis connection failed: redis://localhost
   [...]
   [...]/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php:59
   [...]/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php:30

So I propose to catch this specific exception in case of redis is not (locally) supported, in order to be sure that tests stay green.

[nicolas-grekas]

There is already a redis server detection, but it checks for 127.0.0.1, then it uses localhost, which might not be the same (e.g. if localhost is [::1]). I suggest to replace all redis://localhost strings in the tests with redis://127.0.0.1 instead.

[chalasr]

@nicolas-grekas I tried to apply your suggestion, unfortunately it doesn't helped.

In fact the exception doesn't match with \PHPUnit_Framework_Error_Warning, even by removing the if (0 !== strpos('unable to...') { throw $e; } the test continues then fails at the first exception.

Strangely, this error occurs only from the testRedisCachePools, not in the testRedisCustomCachePools. I think I need to investigate what happen in the redis_config.yml.
The catch I added seems to solve it, but the problem may come from the default cache configuration of the framework. WDYT?

[nicolas-grekas]

Ok, then 👍

[fabpot]

Thank you @chalasr.