Skip to content

Commit

Permalink
bug #17964 [FrameworkBundle] Fix PhpDocExtractor registration (dunglas)
Browse files Browse the repository at this point in the history
This PR was merged into the 3.1-dev branch.

Discussion
----------

[FrameworkBundle] Fix PhpDocExtractor registration

| Q             | A
| ------------- | ---
| Branch        | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fix for the fix... (#17931). `class_exists` on an interface will never work. I've tested this one in real condition and it works.

Commits
-------

89467b5 [FrameworkBundle] Fix PhpDocExtractor registration
  • Loading branch information
fabpot committed Mar 1, 2016
2 parents 41b2612 + 89467b5 commit fff5dcf
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -1010,7 +1010,7 @@ private function registerPropertyInfoConfiguration(array $config, ContainerBuild

$loader->load('property_info.xml');

if (class_exists('phpDocumentor\Reflection\DocBlockFactoryInterface')) {
if (interface_exists('phpDocumentor\Reflection\DocBlockFactoryInterface')) {
$definition = $container->register('property_info.php_doc_extractor', 'Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor');
$definition->addTag('property_info.description_extractor', array('priority' => -1000));
$definition->addTag('property_info.type_extractor', array('priority' => -1001));
Expand Down

0 comments on commit fff5dcf

Please sign in to comment.