[FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3 #17931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1010,7 +1010,7 @@ private function registerPropertyInfoConfiguration(array $config, ContainerBuild | |||
|
|
|||
| $loader->load('property_info.xml'); | |||
|
|
|||
| if (class_exists('phpDocumentor\Reflection\ClassReflector')) { | |||
| if (class_exists('phpDocumentor\Reflection\Types\ContextFactory')) { | |||
There was a problem hiding this comment.
We should also check for existence of the phpDocumentor\Reflection\DocBlockFactoryInterface.
|
ping @symfony/deciders Travis failure not related |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Feb 29, 2016
…ng reflection-docblock 3 (dunglas) This PR was squashed before being merged into the 3.1-dev branch (closes #17931). Discussion ---------- [FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Currently, the PHPDoc extractor of PropertyInfo is not registered anymore because #17531 was merged. Commits ------- 6d31365 [FrameworkBundle] Fix PropertyInfo registration when using reflection-docblock 3
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] Fix PhpDocExtractor registration | Q | A | ------------- | --- | Branch | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | n/a | License | MIT | Doc PR | n/a Fix for the fix... (#17931). `class_exists` on an interface will never work. I've tested this one in real condition and it works. Commits ------- 89467b5 [FrameworkBundle] Fix PhpDocExtractor registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the PHPDoc extractor of PropertyInfo is not registered anymore because #17531 was merged.