Public resources refactoring #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across the whole framework now)
The goal is to make things more decoupled and more reusable across different bundles. There will be a PR for the distribution bundle too to simplify the code based on this PR.
|
congrats ! #6000 |
|
A simple usage example: {% extends "TwigBundle::layout.html.twig" %}
{% block body %}
<div class="block">
FOOBAR
</div>
{% endblock %} |
fabpot
added a commit
that referenced
this pull request
Nov 13, 2012
This PR was merged into the master branch. Commits ------- 0159358 refactored CSS, images, templates included in the built-in bundles 812b9b1 replace _ in stylesheets (ids and classes) by - (should be consistent across the whole framework now) 983b2b5 uniformized styles e0aab40 renamed sf-exceptionreset to sf-reset Discussion ---------- Public resources refactoring The first 3 commits are just cosmetic ones. The last one refactors CSS, images, and templates included in the built-in bundles. Right now, everything is tied to the exception pages, but the code can be used standalone. So, the goal is to make things more decoupled and more reusable across different bundles. That way, a bundle can provide pages that look like the other ones in Symfony without the need to duplicate code. See the associated PR for the distribution bundle to see an example. If you want to have a look at the last commit (not sure if it is worth it), you probably want to append ?w=1 to the URL to avoid too much whitespace noise. --------------------------------------------------------------------------- by pborreli at 2012-11-13T09:38:00Z congrats ! #6000 --------------------------------------------------------------------------- by fabpot at 2012-11-13T09:38:39Z A simple usage example: ```jinja {% extends "TwigBundle::layout.html.twig" %} {% block body %} <div class="block"> FOOBAR </div> {% endblock %} ```
fabpot
added a commit
to sensiolabs/SensioDistributionBundle
that referenced
this pull request
Nov 13, 2012
This PR was merged into the master branch. Commits ------- f656890 refactored assets based on the recent changes in Symfony Discussion ---------- refactored assets based on the recent changes in Symfony see symfony/symfony#6000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 3 commits are just cosmetic ones.
The last one refactors CSS, images, and templates included in the built-in bundles. Right now, everything is tied to the exception pages, but the code can be used standalone.
So, the goal is to make things more decoupled and more reusable across different bundles. That way, a bundle can provide pages that look like the other ones in Symfony without the need to duplicate code.
See the associated PR for the distribution bundle to see an example.
If you want to have a look at the last commit (not sure if it is worth it), you probably want to append ?w=1 to the URL to avoid too much whitespace noise.