Hydrogen #1
Merged
Hydrogen #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests and doctests to reflect this change. Arguments to the R_nl() were changed as well.
Tests and doctests added.
|
I just a quick review and this looks great! I would go ahead and merge! |
|
Wow, all I did was ondrej@raven:~/repos/sympy(hydrogen)$ git push origin hydrogen:master Counting objects: 27, done. Delta compression using up to 8 threads. Compressing objects: 100% (19/19), done. Writing objects: 100% (19/19), 4.05 KiB, done. Total 19 (delta 14), reused 0 (delta 0) To git@github.com:sympy/sympy.git cb94e19..bf8910a hydrogen -> master and github automatically noticed that and closed this pull request. Nice! |
Closed
jrioux
referenced
this pull request
in jrioux/sympy
Mar 1, 2012
Closed
This was referenced Jul 4, 2012
Merged
smichr
pushed a commit
that referenced
this pull request
Nov 28, 2012
3532: Pow.is_real fix for base = -1
raoulb
referenced
this pull request
in raoulb/sympy
Dec 31, 2012
Make erfc and erfi functions available to MeijerG integration code
ankit-maverick
pushed a commit
to ankit-maverick/sympy
that referenced
this pull request
Apr 9, 2013
ghost
mentioned this pull request
raoulb
pushed a commit
that referenced
this pull request
Jun 12, 2013
Make erfc and erfi functions tractable for Gruntz algorithm
raoulb
pushed a commit
that referenced
this pull request
Jun 30, 2013
More review on PR 2081: Merged in to PR #2081
smichr
pushed a commit
that referenced
this pull request
Jan 13, 2014
incorporate isolve into inequalities
asmeurer
pushed a commit
that referenced
this pull request
Mar 25, 2014
Continued fractions for dammina
smichr
pushed a commit
that referenced
this pull request
Apr 11, 2014
test flyback removal in Polygon"
smichr
pushed a commit
that referenced
this pull request
May 14, 2014
Add carstimon to AUTHORS/aboutus. Welcome to SymPy!
Merged
smichr
pushed a commit
that referenced
this pull request
Aug 28, 2017
extract common Integral.__new__ code
sidhantnagpal
pushed a commit
that referenced
this pull request
Nov 9, 2018
Execute tm_sympy with /usr/bin/env python
asmeurer
pushed a commit
that referenced
this pull request
Nov 28, 2018
…-pinv Extend Matrix.pinv for rank deficient matrices
smichr
pushed a commit
that referenced
this pull request
May 4, 2019
Update my branch from original sympy branch
oscarbenjamin
pushed a commit
that referenced
this pull request
Aug 19, 2019
use cwd=get_sympy_dir()
sylee957
pushed a commit
that referenced
this pull request
Sep 17, 2019
Saptashrungi
pushed a commit
to Saptashrungi/sympy
that referenced
this pull request
Feb 12, 2020
…ch-1 Update default.html
smichr
pushed a commit
that referenced
this pull request
Feb 24, 2020
split num/den and look only for half
oscarbenjamin
pushed a commit
that referenced
this pull request
Dec 18, 2020
Updating forked repository
ParasPX1
added a commit
to u7122029/sympy_2120
that referenced
this pull request
Oct 30, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have updated my hydrogen energies branch. I think it's ready to go in.
Ondrej