Make :content mandatory #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| validate do |value| | ||
| raise ArgumentError, "Content cannot be whitespace" if value.match(/^\s+$/) | ||
| fail("Content cannot be empty or whitespace") if value.match(/^\s+$/) |
There was a problem hiding this comment.
As pointed out by @vikraman, it's still broken for empty strings, eg:
fact { 'environment': content => '' }If the content is empty or whitespace, facter returns the following error: Fact file /etc/facter/facts.d/$fact.txt was parsed but returned an empty data set This commit defaults it to empty string, and invalidates it
also their default/accepted values
tampakrap
force-pushed
the
content_not_empty
branch
from
2077dec
to
05ad391
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the content is empty or whitespace, facter returns the following error:
Fact file /etc/facter/facts.d/$fact.txt was parsed but returned an empty data setThis commit defaults it to whitespace, which is invalid value