Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make :content mandatory #1

Merged
merged 3 commits into from
Feb 1, 2015
Merged

Make :content mandatory #1

merged 3 commits into from
Feb 1, 2015

Commits on Feb 1, 2015

  1. Use fail() instead of raising ArgumentError for invalid :content

    @tampakrap
    tampakrap committed Feb 1, 2015
    Configuration menu
    Copy the full SHA
    e74771c View commit details
    Browse the repository at this point in the history

  2. Make the :content argument mandatory 

    If the content is empty or whitespace, facter returns the following error:

Fact file /etc/facter/facts.d/$fact.txt was parsed but returned an empty data set

This commit defaults it to empty string, and invalidates it
    @tampakrap
    tampakrap committed Feb 1, 2015
    Configuration menu
    Copy the full SHA
    64198d8 View commit details
    Browse the repository at this point in the history

  3. Document the mandatory/optional arguments 

    also their default/accepted values
    @tampakrap
    tampakrap committed Feb 1, 2015
    Configuration menu
    Copy the full SHA
    05ad391 View commit details
    Browse the repository at this point in the history