Merge pull request #58 from Chris53897/feature/php8-perf

Feature/php8 perf
tattali · Jul 1, 2023 · 2943469 · 2943469
2 parents 218e077 + d3ef642
commit 2943469
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/Event/CalendarEvent.php b/src/Event/CalendarEvent.php
@@ -41,9 +41,9 @@ public function getFilters(): array
         return $this->filters;
     }
 
-    public function addEvent(Event $event): self
+    public function addEvent(Event $event, bool $checkUnique=false): self
     {
-        if (!\in_array($event, $this->events, true)) {
+        if (!$checkUnique || !\in_array($event, $this->events, true)) {
             $this->events[] = $event;
         }
 

diff --git a/tests/Event/CalendarEventTest.php b/tests/Event/CalendarEventTest.php
@@ -6,14 +6,18 @@
 
 use CalendarBundle\Entity\Event;
 use CalendarBundle\Event\CalendarEvent;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class CalendarEventTest extends TestCase
 {
     private \DateTime $start;
     private \DateTime $end;
     private array $filters;
+    /** @var Event&MockObject $eventEntity */
     private $eventEntity;
+    /** @var Event&MockObject $eventEntity2 */
+    private $eventEntity2;
     private CalendarEvent $event;
 
     public function setUp(): void
@@ -23,6 +27,7 @@ public function setUp(): void
         $this->filters = [];
 
         $this->eventEntity = $this->createMock(Event::class);
+        $this->eventEntity2 = $this->createMock(Event::class);
 
         $this->event = new CalendarEvent(
             $this->start,
@@ -40,7 +45,19 @@ public function testItHasRequireValues(): void
 
     public function testItHandleEvents(): void
     {
+        $this->assertCount(0, $this->event->getEvents());
+
         $this->event->addEvent($this->eventEntity);
         $this->assertEquals([$this->eventEntity], $this->event->getEvents());
+        $this->assertCount(1, $this->event->getEvents());
+
+        $this->event->addEvent($this->eventEntity, true);
+        $this->assertCount(1, $this->event->getEvents());
+
+        $this->event->addEvent($this->eventEntity);
+        $this->assertCount(2, $this->event->getEvents());
+
+        $this->event->addEvent($this->eventEntity2, true);
+        $this->assertCount(3, $this->event->getEvents());
     }
 }