"Return to lobby if preferences unavailable" Revengence #19381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't qualify for any jobs they have set. Previously you could only have it set to play a random job (risky and potentially unfun) or play assistant (greytide).
I'll pr an update to your pr that will convert their old preferences to the new system. |
|
Yeah that's unacceptable with the update system we have. |
|
felt wrong to burn a version on something so trivial |
|
It's far worse to burn everyone's preference settings. |
Makes old savefiles properly work in new system.
|
My hero! ...i still think we need a policy to stop the suiciders though. |
|
Test merge please |
|
There might be strange effects of doing a test merge that updates the save file version. Specifically afterward when the save file is now higher than the max. |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A remake of #4308
🆑
add: You now have the ability to automatically "back out" of a round if you miss your chance at all the jobs you have set to low or higher. This is found on the toggle at the bottom of the jobs window
add: Due to a quirk of game mode code this option will fail to work if you've been selected as an antag (what a tragedy!) In this situation, you'll be assigned a random job.
/:cl: