S3::Object now throws error if the object doesn't exists

Fixes #743
thoughtbot · Feb 17, 2012 · 56012bf · 56012bf
1 parent 9ad074a
commit 56012bf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/paperclip/storage/s3.rb b/lib/paperclip/storage/s3.rb
@@ -238,6 +238,8 @@ def exists?(style = default_style)
         else
           false
         end
+      rescue AWS::Errors::Base => e
+        false
       end
 
       def s3_permissions(style = default_style)

diff --git a/test/storage/s3_test.rb b/test/storage/s3_test.rb
@@ -542,6 +542,16 @@ def counter
           assert true
         end
       end
+
+      context 'that the file were missing' do
+        setup do
+          AWS::S3::S3Object.any_instance.stubs(:exists?).raises(AWS::Errors::Base)
+        end
+
+        should 'return false on exists?' do
+          assert !@dummy.avatar.exists?
+        end
+      end
     end
   end