Spatialreg #847
Merged
Spatialreg #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retain SEs of any fixest input, including fixest summary
- Adjustments to tidying fixest summaries - Make `glance.fixest` results depend on the type of model estimated. - Clarify that augment only works on `feols`, `feglm` or `femlm` models
Also simplify tidy.mfx() using fix_data_frame()
- Break out detection of fixest summary - Add some documentation about optional arguments and which types of models `augment.fixest` can handle.
simonpcouch
reviewed
Jun 5, 2020
simonpcouch
reviewed
Jun 5, 2020
| #' @export | ||
| #' @seealso [augment()] | ||
| #' @family spatialreg tidiers | ||
| augment.sarlm <- function(x) { |
There was a problem hiding this comment.
Could you add a ... argument here for compatibility with the generic and @template param_unused_dots roxygen tag?
I I like you udoated my function. If it is ok I extended your script for another model suppoerted
We don't actually need a three-level if() statement. We can simply append if the value exists, and skip if it doesn't. This allows for much simpler code
|
Merged! Thanks.🙂 |
simonpcouch
added a commit
that referenced
this pull request
Jun 8, 2020
simonpcouch
added a commit
that referenced
this pull request
Jun 8, 2020
simonpcouch
added a commit
that referenced
this pull request
Jun 8, 2020
|
Cool! Thank you for your work. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documented methods for spatial autoregressive models of class
sarlmestimated with thespatialregpackage. Begins from code supplied to #841, with some adjustments for style and adding confidence interval on estimates.