NAS-128506 / 24.04.1 / Fix test iscsi auth network (by bmeagherix) #13620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make tests capable less susceptible to network environment * Add sudo before iscsiadm for non-root test runners (cherry picked from commit dbbd64f)
bmeagherix
force-pushed
the
NAS-128506-24.04.1
branch
from
f0e4518
to
bd82486
Compare
bmeagherix
approved these changes
Apr 24, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Fix a bunch of tests that are failing in CI
iscsiadmin tests precede with asudoif we are not running as root.my_ip4a fixture so it only needs to run oncemy_ip4so that it can even handle NAT situations (ssh/SSH_CLIENT)flake8fixesAlso required the ZFS fix in PR #230 (and PR #231)
Original PR: #13618
Jira URL: https://ixsystems.atlassian.net/browse/NAS-128506