New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-128574 / 24.10 / Allow HeaderDigest and DataDigest to be configured for iSCSI targets #13624
base: master
Are you sure you want to change the base?
Conversation
@@ -97,6 +127,18 @@ async def extend(self, data): | |||
), | |||
]), | |||
List('auth_networks', items=[IPAddr('ip', network=True)]), | |||
Dict( | |||
'options', | |||
Str('DataDigest', enum=DigestEnum.choices()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we typically have camelcase parameters. Convention is all lower-case with underscores as-needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but we're exposing raw iSCSI settings, so IMO this is clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yocalebo do you have strong opinion on this one?
Enhance iSCSI APIs to allow some target options to be specified