New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-128574 / 24.10 / Allow HeaderDigest and DataDigest to be configured for iSCSI targets #13624
Open
bmeagherix
wants to merge
7
commits into
master
Choose a base branch
from
NAS-128574
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0d80ca6
Add various iSCSI target parameters as options
bmeagherix f28137e
Add private API iscsi.scst.reset_target_parameter
bmeagherix 30b5123
When updating an iSCSI target reset live target parameters if needed
bmeagherix 293ce90
Add test_33_target_options
bmeagherix fe6048c
Add test_34_target_header_digest
bmeagherix 7e71187
Add iSCSI target options
bmeagherix 7431f49
Update migration
anodos325 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
src/middlewared/middlewared/alembic/versions/24.10/2024-05-02_19-46_iscsi_target_options.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
"""Add iSCSI target options | ||
|
||
Revision ID: fc912643baa2 | ||
Revises: 135a7e02cbec | ||
Create Date: 2024-04-25 19:46:37.356476+00:00 | ||
|
||
""" | ||
from alembic import op | ||
import sqlalchemy as sa | ||
|
||
|
||
# revision identifiers, used by Alembic. | ||
revision = 'fc912643baa2' | ||
down_revision = '135a7e02cbec' | ||
branch_labels = None | ||
depends_on = None | ||
|
||
|
||
def upgrade(): | ||
with op.batch_alter_table('services_iscsitarget', schema=None) as batch_op: | ||
batch_op.add_column(sa.Column('iscsi_target_options', sa.TEXT(), nullable=True)) | ||
|
||
|
||
def downgrade(): | ||
with op.batch_alter_table('services_iscsitarget', schema=None) as batch_op: | ||
batch_op.drop_column('iscsi_target_options') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we typically have camelcase parameters. Convention is all lower-case with underscores as-needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but we're exposing raw iSCSI settings, so IMO this is clearer.
e.g. https://www.rfc-editor.org/rfc/rfc7143#section-13.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yocalebo do you have strong opinion on this one?