Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc example of creating a matrix of all pairwise comparisons #2776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Jul 5, 2023

This is a common thing to want to do

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2776 (c400728) into main (3d4fc51) will not change coverage.
The diff coverage is n/a.

❗ Current head c400728 differs from pull request most recent head 332861f. Consider uploading reports for the commit 332861f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2776   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          30       30           
  Lines       28624    28624           
  Branches     5590     5590           
=======================================
  Hits        25713    25713           
  Misses       1655     1655           
  Partials     1256     1256           
Flag Coverage Δ
c-tests 86.24% <ø> (ø)
lwt-tests 80.13% <ø> (ø)
python-c-tests 67.13% <ø> (ø)
python-tests 99.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4fc51...332861f. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this one on ice until we have the pairwise matrix code up to speed. We won't want people to land on this (much slower) way of doing the same thing.

@jeromekelleher jeromekelleher added this to the Python 0.5.5 milestone Jul 13, 2023
@hyanwong
Copy link
Member Author

Fair point. I guess the API would be different then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants