add_pbs #2777
Open
add_pbs #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
petrelharp
reviewed
Jul 6, 2023
| divergences.shape = (divergences.shape[0], 1, divergences.shape[1]) | ||
| diversities.shape = (diversities.shape[0], 1, diversities.shape[1]) | ||
|
|
||
| fst = np.repeat(1.0, np.product(divergences.shape)) |
There was a problem hiding this comment.
I think it would be better just to call self.Fst( ) directly instead of copying the code.
petrelharp
reviewed
Jul 6, 2023
| ) | ||
| fst.shape = orig_shape | ||
|
|
||
| def cal_pbs(arr_0): |
There was a problem hiding this comment.
I don't think we're gaining anything by separating this out into a function that is immediately called.
petrelharp
reviewed
Jul 6, 2023
|
|
||
| """ | ||
|
|
||
| def pbs_func(sample_set_sizes, flattened, indexes], **kwargs): |
|
I started commenting on the code, @atongsa, but noticed a bunch of typos, e.g., Please let us know when you've got code that runs (at least, doesn't have syntax errors)? Or, ask if you have specific questions about the approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sorry i messed and delete my local branch, so the pr #2749 was closed automately;
i don't know how to reopen, so i opened a new pr;
sorry agian;
Closes #2717
PR Checklist: