New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c/CMakeLists.txt #2880
base: main
Are you sure you want to change the base?
Add c/CMakeLists.txt #2880
Conversation
Thanks @lukashuebner, this will be really helpful for CMake users! I wonder if it belongs in the tsk-tbuild-example repo though? It would naturally fit into a |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2880 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 30 30
Lines 30159 30159
Branches 5860 5860
=======================================
Hits 27052 27052
Misses 1778 1778
Partials 1329 1329
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Imho, the right place would be in this repo. Otherwise the user would need to maintain a list of |
I see your point @lukashuebner, but I don't really want to get into maintaining multiple build-systems within tskit. We've chosen meson here as the libraries build system, and the specific point of the tskit-build-examples repo is to give examples of how to build applications using tskit using different build systems. As the dev docs say:
So, it would be great if you could add this to the build examples for other CMake users! |
Great, thanks. Out of interest, did you realise that we had this build-example repo? How was your experience of getting CMake running, and did you find the dev-docs useful? |
I created the |
Maybe we need to signpost this a bit more prominently, say in the README.md in the c directory? Do you build your applications "in tree" here in the tskit source, or do you then install the headers and lib files to your file system somewhere? |
I've been using this
CMakeLists.txt
using the following code in my code for a while now: